Re: unique indexes on partitioned tables - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: unique indexes on partitioned tables
Date
Msg-id CAJGNTeMi58OomMrP_5svJH0oG1cJAkGha-3+FPO5Ba-thcXdEA@mail.gmail.com
Whole thread Raw
In response to Re: unique indexes on partitioned tables  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: unique indexes on partitioned tables
List pgsql-hackers
On 12 February 2018 at 15:26, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> Hello,
>
> Thanks, Peter, Jesper, Amit, for reviewing the patch.  Replying to
> all review comments at once:
>

[... v5 of patch attached ...]

Hi Álvaro,

attached a tiny patch (on top of yours) that silence two "variables
uninitilized" warnings.

also noted that if you:

"""
create table t1(i int) partition by hash (i);
create table t1_0 partition of t1 for values with (modulus 2, remainder 0);
create table t1_1 partition of t1 for values with (modulus 2, remainder 1);
create unique index on t1(i);
alter table t1 add primary key using index t1_i_idx ;
"""

the ALTER TABLE ADD PK does not recurse to partitions, which maybe is
perfectly fine because i'm using USING INDEX but it feels like an
oversight to me

--
Jaime Casanova                      www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: pgbench - allow to specify scale as a size
Next
From: Fabien COELHO
Date:
Subject: pgbench - test whether a variable exists