Re: [PATCH] Allow CustomScan nodes to signal projection support - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Allow CustomScan nodes to signal projection support
Date
Msg-id CAJ7c6TPu2T8gWZ+tF1WqXdFcvxsSfWFPtC1fciKqbOCsriC1mg@mail.gmail.com
Whole thread Raw
In response to [PATCH] Allow CustomScan nodes to signal projection support  (Sven Klemm <sven@timescale.com>)
Responses Re: [PATCH] Allow CustomScan nodes to signal projection support
List pgsql-hackers
Hi Sven,

> The attached patch allows CustomScan nodes to signal whether they
> support projection.

I noticed that you didn't change custom-scan.sgml accordingly. The
updated patch is attached. Otherwise, it seems to be fine in terms of
compiling, passing tests etc.

> I named the flag CUSTOMPATH_SUPPORT_PROJECTION similar to the other
> custom node flags, but this would revert the current logic

This seems to be a typical Kobayashi Maru situation, i.e any choice is
a bad one. I suggest keeping the patch as is and hoping that the
developers of existing extensions read the release notes.

-- 
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Enhanced error message to include hint messages for redundant options error
Next
From: Amit Kapila
Date:
Subject: Re: Replication slot stats misgivings