Re: UUID v7 - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: UUID v7
Date
Msg-id CAJ7c6TPi8o7+Kn=WtGArDnEfnm=cnrZRfbM-ZDBhyAomuBhr3A@mail.gmail.com
Whole thread Raw
In response to Re: UUID v7  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: UUID v7
List pgsql-hackers
Hi,

> Andrey, many thanks for the updated patch.
>
> LGTM, cfbot is happy and I don't think we have any open items left. So
> changing CF entry status back to RfC.

PFA v14. I changed:

```
elog(ERROR, "Time argument of UUID v7 cannot exceed 6 bytes");
```

... to:

```
ereport(ERROR,
    (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
    errmsg("Time argument of UUID v7 is outside of the valid range")));
```

Which IMO tells a bit more to the average user and is translatable.

> At a quick glance, the patch needs improving English, IMO.

Agree. We could use some help from a native English speaker for this.

-- 
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: Add bump memory context type and use it for tuplesorts
Next
From: David Steele
Date:
Subject: Re: Use of backup_label not noted in log