Re: Missing NULL check after calling ecpg_strdup - Mailing list pgsql-hackers

Hi,

> Here is the corrected patch v3. Changes since v2:
>
> ```
>                 for (con = all_connections; con != NULL; con = con->next)
>                 {
> -                       /* XXX strcmp() will segfault if con->name is NULL */
> -                       if (strcmp(connection_name, con->name) == 0)
> +                       /* Check for NULL to prevent segfault */
> +                       if (con->name != NULL &&
> strcmp(connection_name, con->name) == 0)
>                                 break;
>                 }
>                 ret = con;
> ```
>
> I was tired or something and didn't think of this trivial fix.
>
> As a side note it looks like ecpg could use some refactoring, but this
> is subject for another patch IMO.

Forgot the attachment. Sorry for the noise.