Re: Potential ABI breakage in upcoming minor releases - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Potential ABI breakage in upcoming minor releases
Date
Msg-id CAJ7c6TPage6-mV-MG9Gbsy57m3dUjKM7o060CeU+dkKdxg+Zsw@mail.gmail.com
Whole thread Raw
In response to Re: Potential ABI breakage in upcoming minor releases  (Ants Aasma <ants.aasma@cybertec.at>)
List pgsql-hackers
Hi,

> To add to this list, Christoph Berg confirmed that timescaledb test suite crashes. [1]

Yes changing ResultRelInfo most definetely breaks TimescaleDB. The
extension uses makeNode(ResultRelInfo) and this can't end-up well:

```
static inline Node *
newNode(size_t size, NodeTag tag)
{
    Node       *result;

    Assert(size >= sizeof(Node));    /* need the tag, at least */
    result = (Node *) palloc0(size);
    result->type = tag;

    return result;
}

#define makeNode(_type_)        ((_type_ *) newNode(sizeof(_type_),T_##_type_))
```

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Emre Hasegeli
Date:
Subject: Object identifier types in logical replication binary mode
Next
From: Peter Eisentraut
Date:
Subject: Re: Potential ABI breakage in upcoming minor releases