Re: [PATCH] Support Int64 GUCs - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Support Int64 GUCs
Date
Msg-id CAJ7c6TPWJJpzgtXuEQ6ARrSYUeHnrX=VTo_n0UghcrsC20UgTg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Support Int64 GUCs  (Pavel Borisov <pashkin.elfe@gmail.com>)
List pgsql-hackers
Hi Pavel,

> I think the direction is good and delivering 64-bit GUCs is very much worth committing.
> The patch itself looks good, but we could need to add locks against concurrently modifying 64-bit values, which could
benon-atomic on older architectures.
 

Thanks for the feedback.

> I think 12345678912345 is good enough. Underscore dividers make reading little bit easier but look weird overall. I
can'tremember other places where we output long numbers with dividers.
 

We already support this in SQL:

psql (18devel)
=# SELECT 123_456;
 ?column?
----------
   123456

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Pavel Borisov
Date:
Subject: Re: [PATCH] Support Int64 GUCs
Next
From: Ranier Vilela
Date:
Subject: Re: Avoid dead code (contrib/pg_visibility/pg_visibility.c)