Hi Maxim,
> Here is a new patch set.
> I've added comments and make use GetClogDirName call in copy_subdir_files.
Jacob Champion pointed out (offlist, cc:'ed) that we may be wrong on this one:
> 0001 patch changes the SLRU internals without affecting the callers.
> 0001 - should make SLRU internally 64–bit, no effects from "outside"
... and apparently Jacob is right.
Besides other things 0001 modifies CLOG_ZEROPAGE and CLOG_TRUNCATE WAL
records - it makes changes to WriteZeroPageXlogRec() and
WriteTruncateXlogRec() and corresponding changes to clog_desc() and
clog_redo().
Firstly, it means that the patch doesn't change what it claims to
change. I think these changes should be part of 0002.
Secondly, shouldn't we introduce a new WAL record type in order to
make the code backward compatible with previous PG versions? I'm not
100% sure how the upgrade procedure works in all the details. If it
requires the DBMS to be gracefully shut down before the upgrade then
we are probably fine here.
--
Best regards,
Aleksander Alekseev
