Postgres Pro
Downloads
Home   >   mailing lists

Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere. - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.
Date
Msg-id CAJ7c6TOe2MprcGv0OYDvm7QjontgfxkhsigWcm=1eC3+kTSCMQ@mail.gmail.com
Whole thread Raw
In response to GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.  (Amul Sul <sulamul@gmail.com>)
List pgsql-hackers
Tree view 
Hi Amul,

> -   *tli = replayTLI;
> +   if (tli)
> +       *tli = replayTLI;

I would guess the difference here is that GetStandbyFlushRecPtr is
static. It is used 3 times in walsender.c and in all cases the
argument can't be NULL.

So I'm not certain what we will gain from the proposed check.

-- 
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: making relfilenodes 56 bits
Next
From: Bharath Rupireddy
Date:
Subject: Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?