Re: pgsql: injection_points: Add injection_points_list() - Mailing list pgsql-committers

From Aleksander Alekseev
Subject Re: pgsql: injection_points: Add injection_points_list()
Date
Msg-id CAJ7c6TOVA-DPdK9pL5OGnap1rvj+y-hgYwgTMmpjUQvdrGNThA@mail.gmail.com
Whole thread Raw
In response to pgsql: injection_points: Add injection_points_list()  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
Hi Michael,

> injection_points: Add injection_points_list()
>
> This function can be used to retrieve the information about all the
> injection points attached to a cluster, providing coverage for
> InjectionPointList() introduced in 7b2eb72b1b8c.
>
> The original proposal turned around a system function, but that would
> not be backpatchable to stable branches.  It was also a bit weird to
> have a system function that fails depending on if the build allows
> injection points or not.

In injection_points_list() isn't `memset(values, 0, sizeof(values))`
redundant? Also perhaps we want to pfree inj_points.

These are minor issues of course.



pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
Next
From: Jacob Champion
Date:
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.