Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment
Date
Msg-id CAJ7c6TO=8oHfVhevUKEYJOpER=x+NhDofa4oOsxUYAouBwCwzg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment  (Junwang Zhao <zhjwpku@gmail.com>)
List pgsql-hackers
Hi,

> > On Mon, Aug 28, 2023 at 09:46:07PM +0800, Junwang Zhao wrote:
> > > Yeah, it makes sense to me, or maybe just `PQputCopyEnd(...) == -1`,
> > > let's wait for some other opinions.
> >
> > One can argue that PQputCopyEnd() returning 0 could be possible in an
> > older version of libpq these callers are linking to, but this has
> > never existed from what I can see (just checked down to 8.2 now).
> > Anyway, changing these callers may create some backpatching conflicts,
> > so I'd let them as they are, and just fix the comment.
>
> sure, thanks for the explanation.

The patch was applied in 8bf7db02 [1] and I assume it's safe to close
the corresponding CF entry [2].

Thanks, everyone.

[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=8bf7db0285dfbc4b505c8be4c34ab7386eb6297f
[2]: https://commitfest.postgresql.org/44/4521/

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Anthonin Bonnefoy
Date:
Subject: Re: POC: Extension for adding distributed tracing - pg_tracing
Next
From: Ranier Vilela
Date:
Subject: Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)