Re: [PATCH] Check more invariants during syscache initialization - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Check more invariants during syscache initialization
Date
Msg-id CAJ7c6TO72KrW7VrzYKBJumCPzUeBAiRTo-+9ro3Wrjpe+Z1-ZQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Check more invariants during syscache initialization  (Zhang Mingli <zmlpostgres@gmail.com>)
List pgsql-hackers
Hi Zhang,

> That remind me to have a look other codes, and a grep search `oid != 0` show there are several files using old != 0.
>
> ```
> .//src/bin/pg_resetwal/pg_resetwal.c: if (set_oid != 0)
> .//src/bin/pg_resetwal/pg_resetwal.c: if (set_oid != 0)
> .//src/bin/pg_dump/pg_backup_tar.c: if (oid != 0)
> .//src/bin/pg_dump/pg_backup_custom.c: while (oid != 0)
> .//src/bin/pg_dump/pg_backup_custom.c: while (oid != 0)
> ```
> That is another story…I would like provide a patch if it worths.

Good catch. Please do so.

--
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: WaitForOlderSnapshots in DETACH PARTITION causes deadlocks
Next
From: Alvaro Herrera
Date:
Subject: Re: cataloguing NOT NULL constraints