Re: Avoid use deprecated Windows Memory API - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Avoid use deprecated Windows Memory API
Date
Msg-id CAJ7c6TO3JSH5aSqnwFHsQUkHs7pmFsQ5poo0hkaqstS7B=eaGg@mail.gmail.com
Whole thread Raw
In response to Re: Avoid use deprecated Windows Memory API  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi Alvaro,

> In what way is this code cleaner?  I argue it is the opposite.

Well, I guess it depends on the perspective. There are a bit more
lines of code for sure. So if "less code is better" is the criteria,
then no, the new code is not cleaner. If the criteria is to use an API
according to the spec provided by the vendor, to me personally the new
code looks cleaner.

This being said I don't have a strong opinion on whether this patch
should be accepted or not. I completely agree that MS will actually
keep LocalAlloc() indefinitely for backward compatibility with
existing applications, as the company always did.

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Avoid use deprecated Windows Memory API
Next
From: Ranier Vilela
Date:
Subject: Re: Avoid use deprecated Windows Memory API