Re: Remove unused fields in ReorderBufferTupleBuf - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Remove unused fields in ReorderBufferTupleBuf
Date
Msg-id CAJ7c6TNzLpK9uy0P0yqA8XesKd=Ai6sMtEzux_=oOV0L9yvT2A@mail.gmail.com
Whole thread Raw
In response to Re: Remove unused fields in ReorderBufferTupleBuf  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: Remove unused fields in ReorderBufferTupleBuf
Re: Remove unused fields in ReorderBufferTupleBuf
List pgsql-hackers
Hi,

> Here is the corrected patch. I added it to the nearest CF [1].

I played a bit more with the patch. There was an idea to make
ReorderBufferTupleBufData an opaque structure known only within
reorderbyffer.c but it turned out that replication/logical/decode.c
accesses it directly so I abandoned that idea for now.

> Alternatively we could convert ReorderBufferTupleBufData macro to an
> inlined function. At least it will add some type safety.

Here is v3 that implements it too as a separate patch.

Apologies for the noise.

-- 
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: cataloguing NOT NULL constraints
Next
From: Alvaro Herrera
Date:
Subject: Re: WaitForOlderSnapshots in DETACH PARTITION causes deadlocks