Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests
Date
Msg-id CAJ7c6TNcuo8jF+uFv5nWx8XTumg0Dqzyz7ynpFoK_s0DsW63jA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
Hi Andrew,

> I don't think we can protect against all possible user names. Wouldn't it be better to run the tests under an OS user
witha different name, like "marmaduke"? ("user" is a truly terrible default user name).
 

100% agree. The point is not to protect against all possible user
names but merely to reduce the likelihood of the problem. For this
particular test there is no difference which keyword to use for the
test. I realize this is a minor problem, however the fix is trivial
too.

-- 
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests
Next
From: Peter Geoghegan
Date:
Subject: Re: Show various offset arrays for heap WAL records