Re: [PATCH] Split varlena.c into varlena.c and bytea.c - Mailing list pgsql-hackers

Hi Michael,

> /* text_name()
>  * Converts a text type to a Name type.
>  */
>
> Not related to this patch, sorry for the regression, just noticed
> a nit while looking at the diffs of what you have here..  This one, as
> well as name_text(), uses a comment block that is inconsistent with
> the format we have in the tree.  It's a bit surprising that pgindent
> is not picking up that.

Good observation!

I experimented with pgindent a bit. This is an effect of the -nfc1
flag i.e. format_col1_comments=OFF. Unfortunately just removing it has
undesired side effects so we will have to modify pg_bsd_indent a bit,
apparently somewhere here:

pr_commnet.c:
```
    if (ps.col_1 && !format_col1_comments) {    /* if comment starts in column
                         * 1 it should not be touched */
```

I will start a new thread and propose an appropriate patch.

-- 
Best regards,
Aleksander Alekseev