Re: [PATCH] Slight improvement of worker_spi.c example - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Slight improvement of worker_spi.c example
Date
Msg-id CAJ7c6TMsQw2UJCPu9w_SqPdc2+eH7+e=Rj1iQ2+bi9VMaeEQpg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Slight improvement of worker_spi.c example  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: [PATCH] Slight improvement of worker_spi.c example
List pgsql-hackers
Hi,

> That being said this module is really naive and has so many problems that I
> don't think it's actually helpful as coding guidelines for anyone who wants to
> create a non toy extension using bgworkers.

Agree. It is a simple example and I don't think it's going to be
useful to make a complicated one out of it.

The order of the calls it currently uses however may be extremely
confusing for newcomers. It creates an impression that this particular
order is extremely important while in fact it's not and it takes time
to figure this out.

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: [PATCH] Slight improvement of worker_spi.c example
Next
From: Ranier Vilela
Date:
Subject: Re: Avoid unused value (src/fe_utils/print.c)