Re: Some oversights in query_id calculation - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Some oversights in query_id calculation
Date
Msg-id CAJ7c6TMpQNTrmemB7d1gOhX2WiXtooSfPCTvAd+DkX2c9pNZgw@mail.gmail.com
Whole thread Raw
In response to Some oversights in query_id calculation  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Some oversights in query_id calculation  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
Hi Julien,

> I'm attaching a patch that fixes those, with regression tests to reproduce each
> problem.

I believe something could be not quite right with the patch. Here is what I did:

$ git apply ...
# revert the changes in the code but keep the new tests
$ git checkout src/backend/utils/misc/queryjumble.c
$ ./full-build.sh && single-install.sh && make installcheck-world

... where named .sh scripts are something I use to quickly check a patch [1].

I was expecting that several tests will fail but they didn't. Maybe I
missed something?

[1]: https://github.com/afiskon/pgscripts

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: Built-in connection pooler
Next
From: Greg Nancarrow
Date:
Subject: Re: Parallel INSERT SELECT take 2