Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Check more invariants during syscache initialization - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Check more invariants during syscache initialization
Date
Msg-id CAJ7c6TMiGRB2BWpmgEWONzRqdO56WOtd=oNkugaieOj-RNJZHw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Check more invariants during syscache initialization  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: [PATCH] Check more invariants during syscache initialization  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
Hi,

> Shouldn't these be calling `OidIsValid(…)`, not comparing directly to
> `InvalidOid`?

They should, thanks. Here is the updated patch. I made sure there are
no others != InvalidOid checks in syscache.c and catcache.c which are
affected by my patch. I didn't change any other files since Zhang
wants to propose the corresponding patch.

--
Best regards,
Aleksander Alekseev
Attachment

pgsql-hackers by date:

Previous
From: Anthonin Bonnefoy
Date:
Subject: Re: POC: Extension for adding distributed tracing - pg_tracing
Next
From: Matthias van de Meent
Date:
Subject: Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan