Postgres Pro
Downloads
Home   >   mailing lists

Re: Add common function ReplicationOriginName. - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Add common function ReplicationOriginName.
Date
Msg-id CAJ7c6TMVjmNmqqGkYM2uwdFnZUAf39ViSS+P3WxccB5BZ4VAVw@mail.gmail.com
Whole thread Raw
In response to Add common function ReplicationOriginName.  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Add common function ReplicationOriginName.
List pgsql-hackers
Tree view 
Hi Peter,

> PSA a patch to add a common function ReplicationOriginName

The patch looks good to me.

One nitpick I have is that the 2nd argument of snprintf is size_t
while we are passing int's. Your patch is consistent with the current
implementation of ReplicationOriginNameForTablesync() and similar
functions in tablesync.c. However I would like to mention this in case
the committer will be interested in replacing ints with Size's while
on it.


-- 
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Himanshu Upadhyaya
Date:
Subject: Re: HOT chain validation in verify_heapam()
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Patch to address creation of PgStat* contexts with null parent context