Re: Inlining of couple of functions in pl_exec.c improves performance - Mailing list pgsql-hackers

From Amit Khandekar
Subject Re: Inlining of couple of functions in pl_exec.c improves performance
Date
Msg-id CAJ3gD9dUDpmUD5DKkmCEXuADDwQ0OOntkC+4LHmz7RL0MMtpog@mail.gmail.com
Whole thread Raw
In response to Re: Inlining of couple of functions in pl_exec.c improves performance  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, 4 Jul 2020 at 01:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I did some performance testing on 0001+0002 here, and found that
> for me, there's basically no change on x86_64 but a win of 2 to 3
> percent on aarch64, using Pavel's pi_est_1() as a representative
> case for simple plpgsql statements.  That squares with your original
> results I believe.  It's not clear to me whether any of the later
> tests in this thread measured these changes in isolation, or only
> with 0003 added.

Yeah I had the same observation. 0001+0002 seems to benefit mostly on
aarch64. And 0003 (exec_case_value) benefited both on amd64 and
aarch64.

>
> Anyway, that's good enough for me, so I pushed 0001+0002 after a
> little bit of additional cosmetic tweaking.
>
> I attach your original 0003 here (it still applies, with some line
> offsets).  That's just so the cfbot doesn't get confused about what
> it's supposed to test now.

Thanks for pushing all the three !

Thanks,
-Amit Khandekar
Huawei Technologies



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Next
From: Hamid Akhtar
Date:
Subject: Re: WIP/PoC for parallel backup