Do we need to set TOASTCOL_INCOMPRESSIBLE while trying to externalize it, the comment say "ignore on subsequent compression passes" but after this will there be more compression passes? If we need to
set this TOASTCOL_INCOMPRESSIBLE then comment should explain this.
That was a mistake, this flag is not required at this point, as the attribute is externalized it will be marked as TOASTCOL_IGNORE, and such columns are not considered for compression, I removed it. Thanks for pointing it out.