Re: PG compilation error with Visual Studio 2015/2017/2019 - Mailing list pgsql-hackers

Let me explain further, in pg_config_os.h you can check that the value of  _WIN32_WINNT is solely based on checking _MSC_VER. This patch should also be meaningful for WIN32 builds using MinGW, or we might see this issue reappear in those  systems if update the  MIN_WINNT value to more current OS versions. So, I still think  _WIN32_WINNT is a better option.

I still see the same last lines in both #ifdef blocks, and pgindent might change a couple of lines to:

+ MultiByteToWideChar(CP_ACP, 0, winlocname, -1, wc_locale_name,
+ LOCALE_NAME_MAX_LENGTH);
+
+ if ((GetLocaleInfoEx(wc_locale_name, LOCALE_SNAME,
+ (LPWSTR)&buffer, LOCALE_NAME_MAX_LENGTH)) > 0)
+ {

Please open an item in the commitfest for this patch.