Re: json api WIP patch - Mailing list pgsql-hackers

From Merlin Moncure
Subject Re: json api WIP patch
Date
Msg-id CAHyXU0xywF4M3TJL6FGMm=19mjA+9v0dGcxTDv51RzGzFa4s1Q@mail.gmail.com
Whole thread Raw
In response to Re: json api WIP patch  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: json api WIP patch
Re: json api WIP patch
List pgsql-hackers
On Fri, Jan 4, 2013 at 3:03 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> I understand - but hstore isn't in core  - so it should not be precedent
>
> regexp_split_to_table
>
> I am not native speaker, it sounds little bit strange - but maybe
> because I am not native speaker :)

it's common usage: http://api.jquery.com/jQuery.each/

the patch looks fabulous.  There are a few trivial whitespace issues
yet and I noticed a leaked hstore comment@ 2440:
+     /*
+      * if the input hstore is empty, we can only skip the rest if we were
+      * passed in a non-null record, since otherwise there may be issues with
+      * domain nulls.
+      */

merlin



pgsql-hackers by date:

Previous
From: Boszormenyi Zoltan
Date:
Subject: Re: Review of "pg_basebackup and pg_receivexlog to use non-blocking socket communication", was: Re: Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown
Next
From: Tom Lane
Date:
Subject: Re: Improve compression speeds in pg_lzcompress.c