Re: bug in json_to_record with arrays - Mailing list pgsql-hackers

From Merlin Moncure
Subject Re: bug in json_to_record with arrays
Date
Msg-id CAHyXU0wj50FUUj8V2YR+8YqzS=Xz3Ts=0Rdd=F9GhohVvHogRg@mail.gmail.com
Whole thread Raw
In response to Re: bug in json_to_record with arrays  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: bug in json_to_record with arrays  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Dec 1, 2014 at 3:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Josh Berkus <josh@agliodbs.com> writes:
>> On 12/01/2014 12:30 PM, Tom Lane wrote:
>>> Code-wise, yeah, but it would put some pressure on the translators.
>>>
>>> What did you think of the new error texts in themselves?
>
>> I would prefer "invalid input syntax" to "malformed array literal", but
>> I'll take anything we can backpatch.
>
> I think if we're changing them at all, it's about the same cost
> no matter what we change them to exactly.
>
> I'd be good with going to "invalid input syntax" if we also change
> record_in to match.  Anyone have a feeling pro or con about that?

I don't know.  "malformed array literal" is a mighty big clue that you
have a bad "postgres format" array literal and will be well supported
by googling -- this problem isn't new.

merlin



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: bug in json_to_record with arrays
Next
From: Tomas Vondra
Date:
Subject: excessive amounts of consumed memory (RSS), triggering OOM killer