On Mon, Aug 5, 2024 at 8:10 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shubhab.
>
> Here are some more review comments for the v23-0001.
>
> ======
> 011_generated.pl b/src/test/subscription/t/011_generated.pl
>
> nitpick - renamed /regress_pub/regress_pub_tab1/ and
> /regress_sub1/regress_sub1_tab1/
> nitpick - typo /inital data /initial data/
> nitpick - typo /snode_subscriber2/node_subscriber2/
> nitpick - tweak the combo initial sync comments and messages
> nitpick - /#Cleanup/# cleanup/
> nitpick - tweak all the combo normal replication comments
> nitpick - removed blank line at the end
>
> ~~~
>
> 1. Refactor tab_gen_to_missing initial sync tests.
>
> I moved the tab_gen_to_missing initial sync for node_subscriber2 to be
> back where all the other initial sync tests are done.
> See the nitpicks patch file.
>
> ~~~
>
> 2. Refactor tab_nogen_to_gen initial sync tests
>
> I moved all the tab_nogen_to_gen initial sync tests back to where the
> other initial sync tests are done.
> See the nitpicks patch file.
>
> ~~~
>
> 3. Added another test case:
>
> Because the (current PG17) nogen-to-gen initial sync test case (with
> copy_data=true) gives an ERROR, I have added another combination to
> cover normal replication (e.g. using copy_data=false).
> See the nitpicks patch file.
>
> (This has exposed an inconsistency which IMO might be a PG17 bug. I
> have included TAP test comments about this, and plan to post a
> separate thread for it later).
>
> ~
>
> 4. GUC
>
> Moving and adding more CREATE SUBSCRIPTION exceeded some default GUCs,
> so extra configuration was needed.
> See the nitpick patch file.
>
I have fixed all the comments. The attached Patch(v24-0001) contains
all the changes.
Thanks and Regards,
Shubham Khanna.
