Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. - Mailing list pgsql-hackers

On Wed, Mar 19, 2025 at 2:14 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Mar 19, 2025 at 12:29 PM Hayato Kuroda (Fujitsu)
> <kuroda.hayato@fujitsu.com> wrote:
> >
> > One comment for the API. Currently the patch introduces new option '--remove',
> > and the short term is '-r'. My suggestion is to use '-R' instead.
> >
> > Background
> > ==========
> > IIUC, we've planned to put outut-logs in some files on the directory [1].
> > This follows what pg_ugprade does.
> >
> > In pg_uprade, -r means "retain SQL and log files even after successful completion" [2].
> > Normally logs would be removed after the sucessful upgrade, but they would not with
> > the option.
> >
> > If we use -r for removing objects in pg_createsubscriber, it would be conflicted
> > with the short term of --retain. This is confusing for users.
> >
>
> We have discussed in the past and in this thread as well to have a
> functionality like pg_upgrade to have LOG and or SQL files in which
> case we may need to have an option for --retain (-r) similar to
> pg_upgrade. So, using -R for this option sounds reasonable to me.
>
> --

Fixed the mentioned issue by changing -r to -R to avoid conflict with
the --retain option used in pg_upgrade. The attached patch at [1]
contains the required change.

[1] - https://www.postgresql.org/message-id/CAHv8RjKbYaCRrzJzmU6gU0jt85xJftzVV-Hu9rXrkb1yFzYTtA%40mail.gmail.com

Thanks and regards,
Shubham Khanna.