Re: Pgoutput not capturing the generated columns - Mailing list pgsql-hackers

On Wed, Aug 7, 2024 at 1:31 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shubham,
>
> Here are my review comments for patch v24-0001
>
> I think the TAP tests have incorrect expected results for the nogen-to-gen case.
>
> Whereas the HEAD code will cause "ERROR" for this test scenario, patch
> 0001 does not. IMO the behaviour should be unchanged for this scenario
> which has no generated column on the publisher side. So it seems this
> is a bug in patch 0001.
>
> FYI, I have included "FIXME" comments in the attached top-up diff
> patch to show which test cases I think are expecting wrong results.
>

Fixed all the comments. The attached Patch(v25-0001) contains all the changes.

Thanks and Regards,
Shubham Khanna.