Re: [HACKERS] logical decoding of two-phase transactions - Mailing list pgsql-hackers

From Peter Smith
Subject Re: [HACKERS] logical decoding of two-phase transactions
Date
Msg-id CAHut+PuogrYQe4RFSg1_4ZxN1JA8ebQvKJdJZOaSUMUSYKqYPg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] logical decoding of two-phase transactions  (Amit Kapila <amit.kapila16@gmail.com>)
Responses RE: [HACKERS] logical decoding of two-phase transactions
Re: [HACKERS] logical decoding of two-phase transactions
List pgsql-hackers
On Thu, Feb 11, 2021 at 12:46 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> Few other minor comments on
> v38-0004-Add-support-for-apply-at-prepare-time-to-built-i:
> ======================================================================
> 1.
> - * Mark the prepared transaction as valid.  As soon as xact.c marks
> - * MyProc as not running our XID (which it will do immediately after
> - * this function returns), others can commit/rollback the xact.
> + * Mark the prepared transaction as valid.  As soon as xact.c marks MyProc
> + * as not running our XID (which it will do immediately after this
> + * function returns), others can commit/rollback the xact.
>
> Why this change in this patch? Is it due to pgindent? If so, you need
> to exclude this change?

Fixed in V39.

>
> 2.
> @@ -78,7 +78,7 @@ logicalrep_write_commit(StringInfo out, ReorderBufferTXN *txn,
>
>   pq_sendbyte(out, LOGICAL_REP_MSG_COMMIT);
>
> - /* send the flags field (unused for now) */
> + /* send the flags field */
>   pq_sendbyte(out, flags);
>
> Is there a reason to change the above comment?

Fixed in V39.

----------

Please find attached the new 2PC patch set v39*

This fixes some recent feedback comments (see above).

----
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: SQL-standard function body
Next
From: Petr Jelinek
Date:
Subject: Re: Single transaction in the tablesync worker?