Re: pg_createsubscriber: publication-name and subscription-name options do not exist - Mailing list pgsql-docs

From Peter Smith
Subject Re: pg_createsubscriber: publication-name and subscription-name options do not exist
Date
Msg-id CAHut+Pun35SKMabQ8hF=M=Dq108qM64Uk-W2=nos8WB_JgT7hg@mail.gmail.com
Whole thread Raw
In response to pg_createsubscriber: publication-name and subscription-name options do not exist  (PG Doc comments form <noreply@postgresql.org>)
List pgsql-docs
Hi Shubham,

The patch v5-0001 looks mostly OK to me (visual inspection only).

But, I did notice one other improvement you could make in passing.

1.
-      TABLES</literal></link>.  If <option>publication-name</option> option is
-      not specified, it has the following name pattern:
+      TABLES</literal></link>.  If <option>--publication</option> is not
+      specified, it has the following name pattern:

Instead of saying "it has the following name pattern:", IMO it is better to say:
"the publication has the following name pattern:".

That would make it consistent with the similar sentences which are saying:
"... the replication slot has the following name pattern:
"... the subscription has the following name pattern:"

======
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-docs by date:

Previous
From: Peter Smith
Date:
Subject: Re: pg_createsubscriber: publication-name and subscription-name options do not exist
Next
From: Peter Smith
Date:
Subject: Re: pg_createsubscriber: publication-name and subscription-name options do not exist