Re: Patch: Cover POSITION(bytea,bytea) with tests - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Patch: Cover POSITION(bytea,bytea) with tests
Date
Msg-id CAHut+Pu__h2xC4zvvWTTi6rBgGtEZ-jeia6HLHy=1XMW2Uixiw@mail.gmail.com
Whole thread Raw
In response to Patch: Cover POSITION(bytea,bytea) with tests  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: Patch: Cover POSITION(bytea,bytea) with tests
List pgsql-hackers
+1 for this.

Some minor comments:

1. I thought the new test cases should be located earlier in the file
where there were already a couple of POSITION tests.
(see "-- E021-11 position expression")

2. Maybe one of your test cases can be identical to the example from
the docs [1].
position('\x5678'::bytea in '\x1234567890'::bytea) → 3

======
[1] https://www.postgresql.org/docs/17/functions-binarystring.html

Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Optimization for lower(), upper(), casefold() functions.
Next
From: Roberto Mello
Date:
Subject: Re: New subscriber - looking for an overview of the code