Re: Single transaction in the tablesync worker? - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Single transaction in the tablesync worker?
Date
Msg-id CAHut+PtvSTL13J=aPaZLLm3mjhr0o5zD6jKznS9HT6GEhDW_Hw@mail.gmail.com
Whole thread Raw
In response to Re: Single transaction in the tablesync worker?  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
When looking at the DropSubscription code I noticed that there is a
small difference between the HEAD code and the V29 code when slot_name
= NONE.

HEAD does
------
    if (!slotname)
    {
        table_close(rel, NoLock);
        return;
    }
------

V29 does
------
        if (!slotname)
        {
            /* be tidy */
            list_free(rstates);
            return;
        }
------

Isn't the V29 code missing doing a table_close(rel, NoLock) there?

------
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: Josef Šimánek
Date:
Subject: Re: Improvements and additions to COPY progress reporting
Next
From: Amit Langote
Date:
Subject: Re: ModifyTable overheads in generic plans