typedef struct LogicalDecodingContext - Mailing list pgsql-hackers

From Peter Smith
Subject typedef struct LogicalDecodingContext
Date
Msg-id CAHut+PtfFphZxBYBA8fa7Sq8wAMRCqGBuaR9gCdfCNbPR7E2gA@mail.gmail.com
Whole thread Raw
Responses Re: typedef struct LogicalDecodingContext  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

During a recent code review, I noticed a lot of 'struct
LogicalDecodingContext' usage.

There are many function prototypes where the params are (for no
apparent reason to me) a mixture of structs and typedef structs.

AFAICT just by pre-declaring the typedef struct
LogicalDecodingContext, all of those 'struct LogicalDecodingContext'
can be culled, resulting in cleaner and more consistent function
signatures.

The PG Docs were similarly modified.

PSA patch for this.  It passes make check-world.

(I recognize this is potentially the tip of an iceberg. If this patch
is deemed OK, I can hunt down similar underuse of typedefs for other
structs)

Thoughts?

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: refactoring relation extension and BufferAlloc(), faster COPY
Next
From: Joseph Koshakow
Date:
Subject: Re: Infinite Interval