On Mon, Aug 22, 2022 at 9:25 PM vignesh C <vignesh21@gmail.com> wrote:
>
...
> Few comments:
> 1) I felt no expressions are allowed in case of column filters. Only
> column names can be specified. The second part of the sentence
> confuses what is allowed and what is not allowed. Won't it be better
> to remove the second sentence and mention that only column names can
> be specified.
> + <para>
> + Column list can contain only simple column references. Complex
> + expressions, function calls etc. are not allowed.
> + </para>
>
This wording was lifted verbatim from the commit message [1]. But I
see your point that it just seems to be overcomplicating a simple
rule. Modified as suggested.
> 2) tablename should be table name.
> + <para>
> + A column list is specified per table following the tablename, and
> enclosed by
> + parenthesis. See <xref linkend="sql-createpublication"/> for details.
> + </para>
>
> We have used table name in the same page in other instances like:
> a) The row filter is defined per table. Use a WHERE clause after the
> table name for each published table that requires data to be filtered
> out. The WHERE clause must be enclosed by parentheses.
> b) The tables are matched between the publisher and the subscriber
> using the fully qualified table name.
>
Fixed as suggested.
> 3) One small whitespace issue:
> git am v2-0001-Column-List-replica-identity-rules.patch
> Applying: Column List replica identity rules.
> .git/rebase-apply/patch:30: trailing whitespace.
> if the publication publishes only <command>INSERT</command> operations.
> warning: 1 line adds whitespace errors.
>
Fixed.
~~~
PSA the v3* patch set.
------
[1] https://github.com/postgres/postgres/commit/923def9a533a7d986acfb524139d8b9e5466d0a5
Kind Regards,
Peter Smith.
Fujitsu Australia
