Re: pg_upgrade - typo in verbose log - Mailing list pgsql-hackers

On Thu, May 11, 2023 at 6:30 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 11 May 2023, at 07:41, Peter Smith <smithpb2250@gmail.com> wrote:
>
> > While reviewing another patch for the file info.c, I noticed some
> > misplaced colon (':') in the verbose logs for print_rel_infos().
>
> That spelling was introduced in c2e9b2f28818 which was the initial import of
> pg_upgrade into contrib/ for the 9.0 release (at that time the function was
> relarr_print() which via a few other names was renamed to print_rel_infos() in
> 0a5f1199319).
>
> It's not entirely clear to me if the current spelling is a mistake or
> intentional, but I do agree that your version is an improvement.
>
> To be consistent with other log output in pg_upgrade we should probably also
> wrap the relname and reltblspace in quotes as \"%s.%s\" and \"%s\" (and the
> Database in print_db_infos()).
>

Thanks for checking, and for the feedback.

PSA patch v2 updated as suggested.

------
Kind Regards,
Peter Smith.
Fujitsu Australia