Re: Skip collecting decoded changes of already-aborted transactions - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Skip collecting decoded changes of already-aborted transactions
Date
Msg-id CAHut+PsraMChmh=Tthu9_YHHN_c-mOqM-0pBXHeonhT7vE8qPA@mail.gmail.com
Whole thread Raw
In response to Skip collecting decoded changes of already-aborted transactions  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
Hi, Here are my review comments for patch v9-0001.

These are only trivial nits for some code comments. Everything else
looked good to me.

======
.../replication/logical/reorderbuffer.c

ReorderBufferTruncateTXN:

1.
+ * The given transaction is marked as streamed if appropriate and the caller
+ * asked it by passing 'mark_txn_streaming' being true.

/asked it/requested it/

/being true/as true/

~~~

ReorderBufferPrepare:

2.
+ /*
+ * Remember if the transaction is already aborted to check if we detect
+ * that the transaction is concurrently aborted during the replay.
+ */

SUGGESTION:
Remember if the transaction is already aborted so we can detect when
the transaction is concurrently aborted during the replay.

======
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: "Tristan Partin"
Date:
Subject: Re: Add support for Tcl 9
Next
From: Ashutosh Bapat
Date:
Subject: Re: Enhancing Memory Context Statistics Reporting