Hi,
I was looking at this code recently and noticed the following.
Although the commit [1] removed the ->additional field, some function
comments were not updated to reflect this, so now they seemed a bit
stale.
1. BuildTupleHashTable(...) still says:
----------
...
* additionalsize: size of data stored in ->additional
...
----------
2. Simiarly, LookupTupleHashEntry(...) still says:
----------
...
* false if it existed already. ->additional_data in the new entry has
* been zeroed.
...
----------
======
[1] https://github.com/postgres/postgres/commit/626df47ad9db809dc8f93330175ab95b75914721
Kind Regards,
Peter Smith.
Fujitsu Australia
