Hi Vignesh, Here are my review comments for the latest patchset:
Patch v20240813-0001. No comments
Patch v20240813-0002. No comments
Patch v20240813-0003. No comments
Patch v20240813-0004. See below
Patch v20240813-0005. No comments
//////
Patch v20240813-0004
======
src/backend/catalog/pg_subscription.
GetSubscriptionRelations:
nit - modify a condition for readability
======
src/backend/commands/subscriptioncmds.c
fetch_sequence_list:
nit - changed the WARNING message. /parameters differ
between.../parameters differ for.../ (FYI, Chat-GPT agrees that 2nd
way is more correct)
nit - other minor changes to the message and hint
======
.../replication/logical/sequencesync.c
1. LogicalRepSyncSequences
+ ereport(DEBUG1,
+ errmsg("logical replication synchronization for subscription \"%s\",
sequence \"%s\" has finished",
+ get_subscription_name(subid, false), get_rel_name(done_seq->relid)));
DEBUG logs should use errmsg_internal. (fixed also nitpicks attachment).
~
nit - minor change to the log message counting the batched sequences
~~~
process_syncing_sequences_for_apply:
nit - /sequence sync worker/seqeuencesync worker/
======
src/backend/utils/misc/guc_tables.c
nit - /max workers/maximum number of workers/ (for consistency because
all other GUCs are verbose like this; nothing just says "max".)
======
src/test/subscription/t/034_sequences.pl
nit - adjust the expected WARNING message (which was modified above)
======
Kind Regards,
Peter Smith.
Fujitsu Australia
