Re: pg_createsubscriber TAP test wrapping makes command options hard to read. - Mailing list pgsql-hackers

On Fri, Dec 13, 2024 at 5:03 AM Dagfinn Ilmari Mannsåker
<ilmari@ilmari.org> wrote:
>
> On Thu, 12 Dec 2024, at 17:52, Andrew Dunstan wrote:
> > On 2024-12-12 Th 12:08 PM, Dagfinn Ilmari Mannsåker wrote:
> >>
> >> command_ok(
> >>      [
> >>              'pg_dump',
> >>              ('--schema', 'pg_catalog'),
> >>              ('-f', $outputdir . '/catalogs_primary.dump'),
> >>              '--no-sync',
> >>              ('-p', $node_primary->port),
> >>              '--no-unlogged-table-data',
> >>              'regression'
> >>      ],
> >>      'dump catalogs of primary server');
> >>
> >> I think the fat comma is much nicer than this, so I'd like to convert
> >> these too (and replace some of the concatenations with interpolation).
> >>
> >> Technically the quotes aren't necessary around single-dash options
> >> before => since unary minus works on strings as well as numbers, but
> >> I'll leave them in for consistency.
> >
> > I'd rather get rid of those and just use the long options.
>
> Yeah, that is more self-documenting, so I'll do that while I'm at it.
>
> --

Your fat-comma solution is much better than something I could have
come up with. Thanks for taking this on.

======
Kind Regards,
Peter Smith.
Fujitsu Australia