Re: Small documentation improvement for ALTER SUBSCRIPTION - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Small documentation improvement for ALTER SUBSCRIPTION
Date
Msg-id CAHut+PsNUWpd8wUFNCAUKOZ4ay=YDNeAx9+LGs=czKfv4EKQmw@mail.gmail.com
Whole thread Raw
In response to Re: Small documentation improvement for ALTER SUBSCRIPTION  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Small documentation improvement for ALTER SUBSCRIPTION  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > Hi all,
> >
> > When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh
> > options' in the following paragraph is not tagged:
> >
> > ---
> > Additionally, refresh options as described under REFRESH PUBLICATION
> > may be specified, except in the case of DROP PUBLICATION.
> > ---
> >
> > When I read it for the first time, I got confused because we actually
> > have the 'refresh' option and this description in the paragraph of the
> > 'refresh' option. I think we can improve it by changing to
> > '<replaceable>refresh_option</replaceable>'. Thoughts?
> >
>
> I see that one can get confused but how about changing it to
> "Additionally, refresh options as described under <literal>REFRESH
> PUBLICATION</literal> (<replaceable>refresh_option</replaceable>) may
> be specified,.."? I think keeping "refresh options" in the text would
> be good because there could be multiple such options.
>

I feel like it would be better to reword it in some way that avoids
using parentheses because they look like part of the syntax instead of
just part of the sentence.

------
Kind Regards,
Peter Smith.
Fujitsu Australia.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Assert triggered during RE_compile_and_cache
Next
From: Julien Rouhaud
Date:
Subject: Re: elog.c query_id support vs shutdown