Re: AlterSubscription_refresh "wrconn" wrong variable? - Mailing list pgsql-hackers

From Peter Smith
Subject Re: AlterSubscription_refresh "wrconn" wrong variable?
Date
Msg-id CAHut+PsJ-w=GBx_hP9FUKhRHS9Lb8DvNX+a0dcYrQX8Jp3byhQ@mail.gmail.com
Whole thread Raw
In response to Re: AlterSubscription_refresh "wrconn" wrong variable?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: AlterSubscription_refresh "wrconn" wrong variable?
Re: AlterSubscription_refresh "wrconn" wrong variable?
List pgsql-hackers
On Wed, May 5, 2021 at 12:35 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Peter Smith <smithpb2250@gmail.com> writes:
> > This patch replaces the global "wrconn" in AlterSubscription_refresh with a local variable of the same name, making
itconsistent with other functions in subscriptioncmds.c (e.g. DropSubscription).
 
> > The global wrconn is only meant to be used for logical apply/tablesync worker.
> > Using the global/incorrect wrconn in AlterSubscription_refresh doesn't normally cause any problems, but harm is
stillposslble if the apply worker ever manages to do a subscription refresh. e.g. see [1]
 
>
> Hm.  I would actually place the blame for this on whoever thought
> it was okay to name a global variable something as generic as
> "wrconn".   Let's rename that while we're at it, say to something
> like "tablesync_wrconn" (feel free to bikeshed).

PSA v3 of the patch. Same as before, but now also renames the global
variable from "wrconn" to "lrep_worker_wrconn".

------
Kind Regards,
Peter Smith
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: decoupling table and index vacuum
Next
From: Etsuro Fujita
Date:
Subject: Re: Asynchronous Append on postgres_fdw nodes.