Re: Pgoutput not capturing the generated columns - Mailing list pgsql-hackers

Hi Vignesh,

Here are my review comments for patch v49-0001.

======
src/backend/catalog/pg_publication.c

1. check_fetch_column_list

+bool
+check_fetch_column_list(Publication *pub, Oid relid, MemoryContext mcxt,
+ Bitmapset **cols)
+{
+ HeapTuple cftuple = NULL;
+ Datum cfdatum = 0;
+ bool found = false;
+

1a.
The 'cftuple' is unconditionally assigned; the default assignment
seems unnecessary.

~

1b.
The 'cfdatum' can be declared in a lower scope (in the if-block).
The 'cfdatum' is unconditionally assigned; the default assignment
seems unnecessary.

======
Kind Regards,
Peter Smith.
Fujitsu Australia