Re: Add common function ReplicationOriginName. - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Add common function ReplicationOriginName.
Date
Msg-id CAHut+PsB9hEEU-JHqTUBL3bv--vesUvThYr1-95ZyG5PkF9PQQ@mail.gmail.com
Whole thread Raw
In response to Re: Add common function ReplicationOriginName.  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
On Wed, Sep 21, 2022 at 8:22 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
...
> > > On Wed, Sep 21, 2022 at 3:23 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > ...
> > >
> > > > Can't we use the existing function ReplicationOriginNameForTablesync()
> > > > by passing relid as InvalidOid for this purpose? We need a check
> > > > inside to decide which name to construct, otherwise, it should be
> > > > fine. If we agree with this, then we can change the name of the
> > > > function to something like ReplicationOriginNameForLogicalRep or
> > > > ReplicationOriginNameForLogicalRepWorkers.
> > > >
...
>
> OK, I can unify the 2 functions as you suggested. I will post another
> patch in a few days.
>

PSA patch v3 to combine the different replication origin name
formatting in a single function ReplicationOriginNameForLogicalRep as
suggested.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: "wangw.fnst@fujitsu.com"
Date:
Subject: RE: Perform streaming logical transactions by background workers and parallel apply
Next
From: Amit Kapila
Date:
Subject: Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot