Re: pg_scanner - patch no.1 - Mailing list pgadmin-hackers

From Vladimir Kokovic
Subject Re: pg_scanner - patch no.1
Date
Msg-id CAHsHPqeBoXbxVF1z_0k3Fwa-D879JLnSVUavp5J7L6NHQSHt6w@mail.gmail.com
Whole thread Raw
In response to Re: pg_scanner - patch no.1  (Dave Page <dpage@pgadmin.org>)
Responses Re: pg_scanner - patch no.1  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi,

On 11/13/12, Dave Page <dpage@pgadmin.org> wrote:

> Hmm, that's definitely wrong - any parts of the pgadmin3 build target
> should be in $SRC/pgadmin. Having it in xtra/ is acceptable if it's
> being built as a library that then gets linked into other projects,
> but if we're adding to pgadmin3_LDADD, then the code should definitely
> not be in xtra/ but in pgadmin/. I'd prefer it not be a library
> personally, so can you move it please?
>

Moved from xtra/pg_scanners to pgadmin/pg_scanners.

>
> 92 is fine - my point is that we support 3 different types of
> PostgreSQL server, that each may have a 9.2 version with different
> syntax, so if we're including the version number to allow multiple
> scanners in the future, then we should also include something to
> differentiate the forks - eg. pg92 for PostgreSQL, as92 for Postgres
> Plus Advanced Server and gp92 for Greenplum Database.
>

For now, pgadmin/pg_scanners contains only pg92 scanner !

Best regards
Vladimir Kokovic
Belgrade, Serbia, 14.November 2012

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pg_scanner - patch no.1
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Avoid querying the catalogs for toast table setting