Re: bug when apply fast default mechanism for adding new column over domain with default value - Mailing list pgsql-hackers

From Tender Wang
Subject Re: bug when apply fast default mechanism for adding new column over domain with default value
Date
Msg-id CAHewXNnUiWJFe-Bx1obwH2NrvKF6E8CsYp1xL+uRyZE+ec6c7A@mail.gmail.com
Whole thread Raw
In response to Re: bug when apply fast default mechanism for adding new column over domain with default value  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


Tom Lane <tgl@sss.pgh.pa.us> 于2025年4月2日周三 23:15写道:
Tender Wang <tndrwang@gmail.com> writes:
> So let's add CommandCounterIncrement() after calling StoreAttrMissingVal().

Pushed with minor editorialization.  I thought for a bit about whether
the CCI call should be inside StoreAttrMissingVal; but its cohorts in
heap.c don't do their own CCI calls, so this way seems the least
surprising.

Yes, there is no direct call CCI in heap.c.  I also noticed this.
Thanks for pushing. 


--
Thanks, Tender Wang

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: BTScanOpaqueData size slows down tests
Next
From: Bertrand Drouvot
Date:
Subject: Re: Draft for basic NUMA observability