Re: BUG #18871: Cross-partition MERGE fails with unclear internal error - Mailing list pgsql-bugs

From Tender Wang
Subject Re: BUG #18871: Cross-partition MERGE fails with unclear internal error
Date
Msg-id CAHewXNk7L3XxL5fVfKoWYXMHVPYQFN7i42Ui8LB8XwoNOeuEvg@mail.gmail.com
Whole thread Raw
In response to Re: BUG #18871: Cross-partition MERGE fails with unclear internal error  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-bugs


Dean Rasheed <dean.a.rasheed@gmail.com> 于2025年3月29日周六 18:20写道:
On Sat, 29 Mar 2025 at 05:54, Gurjeet Singh <gurjeet@singh.im> wrote:
>
> On Fri Mar 28, 2025 at 7:39 PM PDT, Tender Wang wrote:
>
> > In ExecInitPartitionInfo(), it has comments like:
> >
> > * This duplicates much of the logic in ExecInitMerge(), so something
> > * changes there, look here too.
> >
> I would've expecetd the comment to be in ExecInitMerge(), asking the
> reader to look at other places the logic is duplicated.
>

There already is such a comment a little further up in
ExecInitMerge(), so I didn't bother repeating it.

I've committed the fix, except that I put the test case in merge.sql,
since part_abc_view doesn't exist in back branches of
partition_prune.sql, and it feels more like a MERGE bug anyway.

Agree.
Thanks for pushing. 

--
Thanks,
Tender Wang

pgsql-bugs by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: BUG #18871: Cross-partition MERGE fails with unclear internal error
Next
From: Andrew Dunstan
Date:
Subject: Re: PostgreSQL JDBC 42.7.5 returns an unexpected catalog name