Re: PITR on DROP DATABASE, deleting of the database directory despitethe recovery_target_time set before. - Mailing list pgsql-hackers

From Jean-Christophe Arnu
Subject Re: PITR on DROP DATABASE, deleting of the database directory despitethe recovery_target_time set before.
Date
Msg-id CAHZmTm1X6OhB3dQDw0vyc27Gb3WeO0g3a0YSEPThPxY_-FahEg@mail.gmail.com
Whole thread Raw
In response to Re: PITR on DROP DATABASE, deleting of the database directory despitethe recovery_target_time set before.  (Nicolas Lutic <n.lutic@loxodata.com>)
List pgsql-hackers
Hello,

Le mar. 19 nov. 2019 à 16:15, Nicolas Lutic <n.lutic@loxodata.com> a écrit :

We are aware that this part is tricky and will have little effects on
normal operations, as best practices are to use xid_target or lsn_target.

I'm working with Nicolas and we made some further testing. If we use xid target with inclusive to  false at the next xid after the insert, we end up with the same DELETE/DROP directory behaviour which is quite confusing. One have to choose the xid-1 value with inclusive behaviour to lake it work.

I assume this is the right first thing to document the behaviour. And give some examples on this.

Maybe we could add some documentation in the xlog explanation and a warning in the recovery_target_time and xid in guc doc ?

If there are better places in the docs let us know.

Thanks
 

--
Jean-Christophe Arnu

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: non-exclusive backup cleanup is mildly broken
Next
From: Amit Kapila
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions