Re: BUG #18712: inet value ::2 handling goes not as expected - Mailing list pgsql-bugs

From Denis Feklushkin
Subject Re: BUG #18712: inet value ::2 handling goes not as expected
Date
Msg-id CAHY2gWfDGqZHQB7nKhtmPGBGYxvhS5OqY4k_BaAP5PSwHyW8Tg@mail.gmail.com
Whole thread Raw
In response to Re: BUG #18712: inet value ::2 handling goes not as expected  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #18712: inet value ::2 handling goes not as expected
List pgsql-bugs


вс, 17 нояб. 2024 г. в 20:05, Tom Lane <tgl@sss.pgh.pa.us>:
PG Bug reporting form <noreply@postgresql.org> writes:
> I think that statement
> select '::0.0.0.2'::inet;
> should return '::0.0.0.2' value, not '::2'

> I think this is what was intended in the Postgres sources. But it seems that
> this line is never executed:
> https://github.com/postgres/postgres/blob/7b88529f4363994450bd4cd3c172006a8a77e222/src/port/inet_net_ntop.c#L260

Hmm ... you are right that that code doesn't do what it seems to
intend to, because by the time that we get to this logic we have
i == 7 not i == 6.

Yes, this code block should be placed at first place inside of for loop
 
  But I'm not sure if we should change it after
all this time.  We're about as likely to get complaints as kudos,
I fear.  And the output isn't incorrect, just not-per-style.

I wonder whether ISC ever changed their version?
Looks, they don't used 0x0001 check, so, they version was always as intended

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: Build failure with GCC 15 (defaults to -std=gnu23)
Next
From: Raghu Dev Ramaiah
Date:
Subject: Getting error while building PSQL 17.1 on AIX box