On Thu, May 2, 2013 at 1:28 AM, Dave Page <dpage@pgadmin.org> wrote:
Unfortunately it needs a little tweaking, but that shouldn't be hard:
- I don't believe there's any need to modify the queries in the database designer code (dd/ddmodel/ddDBReverseEnginering.cpp), as the columns you've added aren't used anywhere.
- You've updated dlgIndex to support a new checkbox, but, the patch doesn't include the corresponding update to dlgIndex.xrc that actually places the checkbox on the UI. However.... we don't include controls on dialogues for properties that cannot be changed (either at creation, post creation, or both), so you don't need to include the code changes to dlgIndex anyway.
Ah, sure, that's obvious now :)
The rest of the patch looks good - and as I'm planning to cut the alpha release today, I've committed it, having removed the two changes above.