Request a Demo
Home   >   mailing lists

Re: [PATCH] GROUP BY ALL - Mailing list pgsql-hackers

From David Christensen
Subject Re: [PATCH] GROUP BY ALL
Date
Msg-id CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] GROUP BY ALL  (David Christensen <david@pgguru.net>)
Responses Re: [PATCH] GROUP BY ALL
Re: [PATCH] GROUP BY ALL
Re: [PATCH] GROUP BY ALL
List pgsql-hackers
Tree view 
On Fri, Sep 26, 2025 at 6:16 AM David Christensen <david@pgguru.net> wrote:
>
>
>
> > On Sep 26, 2025, at 3:45 AM, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
> >
> > 
> >
> >> On 26 Sep 2025, at 12:02, Peter Eisentraut <peter@eisentraut.org> wrote:
> >>
> >> maybe someone wants to take this up again.
> >
> > I've compared my old patch with David's, and his version looks better.
> > If David is not going to work on this in nearest future - I'l like to pick up the work.
> > Either way I'll join as reviewer.
> >
> > Thanks!
>
> I’m interested in picking it up again but would appreciate the review.

Here is a rebased version with a few more tests.  I also changed the
main check here to using `!contain_agg_clause` instead of
`!IsA(Aggref))` directly.  (This was defined in `optimizer/clauses.h`,
but we already are pulling in `optimizer.h`, so it felt valid to me.)

David
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: test_json_parser/002_inline is kind of slow
Next
From: Robert Haas
Date:
Subject: Re: Avoiding roundoff error in pg_sleep()