Re: [PATCH] GROUP BY ALL - Mailing list pgsql-hackers

On Fri, Sep 26, 2025 at 11:46 PM David Christensen <david@pgguru.net> wrote:
>
> >
> > I’m interested in picking it up again but would appreciate the review.
>
> Here is a rebased version with a few more tests.  I also changed the
> main check here to using `!contain_agg_clause` instead of
> `!IsA(Aggref))` directly.  (This was defined in `optimizer/clauses.h`,
> but we already are pulling in `optimizer.h`, so it felt valid to me.)
>

hi.
I only briefly browse the patch text file, so forgive me.
seems missing deparse regress tests

i think you may need one test like:

create view v1 as SELECT b, COUNT(*) FROM t1 GROUP BY ALL;
\sv v1